[MERGE] Add ignore patterns into bzr.dev

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>>> But actually, I have bzrlib/.python-eggs and bzrlib/.bzr.log too, so
>>> those patterns shouldn't be rooted, I think.

> .python-eggs was rooted before. And I generally prefer rooted patterns.
> If a file shows up where you don't expect, you should know about it.
> 
> But I realize that running:
> 
> cd bzrlib
> ../bzr selftest
> 
> Will create .python-eggs in bzrlib.
> 
> I think the better thing would be to change the test suite, so that
> TestCase creates a root directory, and sets $HOME to that, instead of
> setting it to the cwd.

I agree-- we shouldn't use the cwd for HOME.

> We need the base test directory for any TestCaseInTempDir, so it doesn't
> seem that bad to move it up one.

It sounds like it will make it marginally more annoying to do
- --keep-output and then explore the testxxxx.tmp directories.  Not a big
deal.

> Mostly I was very surprised that you added .python-eggs to
> DEFAULT_IGNORE rather than adding them to .bzrignore.
> I missed where you were adding it originally.

Yeah, I had second thoughts about that after it was already in.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEqv9N0F+nu1YWqI0RAtUtAJ4/wJjgA/vtiXDtIvfqdUGyShkPkQCeLBxA
c2911peuJPly7+xi5/84Ntc=
=bcey
-----END PGP SIGNATURE-----