[MERGE] Add ignore patterns into bzr.dev

John Arbash Meinel john at arbash-meinel.com
Wed Jul 5 00:41:26 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>>>> Can we please have .python-eggs, .bzr.log and .shelf back?
> 
>>> Those are in there.
>>>
>>> See:
>>> ./.python-egs
>>> ./.shelf
>>> ./.bzr.log
>>>
>>> I'm not sure what you were looking for.
> 
> Oh, silly me.  I need to merge bzr.dev in the tree I was looking at.
> 
> But actually, I have bzrlib/.python-eggs and bzrlib/.bzr.log too, so
> those patterns shouldn't be rooted, I think.
> 
> Aaron

.python-eggs was rooted before. And I generally prefer rooted patterns.
If a file shows up where you don't expect, you should know about it.

But I realize that running:

cd bzrlib
../bzr selftest

Will create .python-eggs in bzrlib.

I think the better thing would be to change the test suite, so that
TestCase creates a root directory, and sets $HOME to that, instead of
setting it to the cwd.
We need the base test directory for any TestCaseInTempDir, so it doesn't
seem that bad to move it up one.

But I don't really care. We can unroot the patterns if you really prefer.

Mostly I was very surprised that you added .python-eggs to
DEFAULT_IGNORE rather than adding them to .bzrignore.
I missed where you were adding it originally.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEqvylJdeBCYSNAAMRAnLWAKChuEdZu08kcnbGT4Qm9vyY4A50QQCdFR+/
6x0IAU1s2bAfr2x4QqTAm3Q=
=5oiE
-----END PGP SIGNATURE-----




More information about the bazaar mailing list