[MERGE] win32 important fix: convert drive letter to uppercase not lowercase

John Arbash Meinel john at arbash-meinel.com
Sat Jun 24 14:16:56 BST 2006

Alexander Belchenko wrote:
> This patch revert urlutils.py functions to convert between local path
> and url on win32 to always convert drive letter to upper case. This code
> was before, but for some reason was changed by John Meinel in his
> win32-fixes branch to lowering case. And lowercasing cause too many
> errors in bzr's commands behaviour (PathcNoChild error) and in selftest
> too.
> Before patch (bzr.dev.revno.1809)
> Ran 2778 tests in 1299.438s
> FAILED (failures=137, errors=224)
> After patch:
> Ran 2778 tests in 1313.860s
> FAILED (failures=42, errors=155)
> I always think this is standard de-facto in windows world: drive letter
> always upper case. I don't googling for confirmation but in every
> windows operations drive letter seems to be uppercased.

+1 from me. I was trying to select something consistent, and I thought
lowercase 'looked' better.
The tests themselves expect to get uppercase, so that is why some of
them fail after your change.

I'm planning on doing a few rounds of win32 development next week. I'm
sorry I left things broken for so long.

I'm hoping that by the end of next week I can get the test suite to
completely pass on win32.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060624/02cd6e43/attachment.pgp 

More information about the bazaar mailing list