[MERGE] win32 important fix: convert drive letter to uppercase not lowercase

Alexander Belchenko bialix at ukr.net
Sat Jun 24 08:17:56 BST 2006

This patch revert urlutils.py functions to convert between local path 
and url on win32 to always convert drive letter to upper case. This code 
was before, but for some reason was changed by John Meinel in his 
win32-fixes branch to lowering case. And lowercasing cause too many 
errors in bzr's commands behaviour (PathcNoChild error) and in selftest too.

Before patch (bzr.dev.revno.1809)

Ran 2778 tests in 1299.438s

FAILED (failures=137, errors=224)

After patch:

Ran 2778 tests in 1313.860s

FAILED (failures=42, errors=155)

I always think this is standard de-facto in windows world: drive letter
always upper case. I don't googling for confirmation but in every
windows operations drive letter seems to be uppercased.

Python 2.4.3 (#69, Mar 29 2006, 17:35:34) [MSC v.1310 32 bit (Intel)] on
Type "help", "copyright", "credits" or "license" for more information.
  >>> import os
  >>> os.getcwd()
  >>> os.chdir('d:')
  >>> os.getcwd()

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: win32-drive-letter-uppercase.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060624/e43e1478/attachment.diff 

More information about the bazaar mailing list