[bug] bzr commit with nothing changed fails with the wrong exception

Martin Pool mbp at canonical.com
Sat Jun 24 00:03:42 BST 2006


On 23 Jun 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> John Arbash Meinel wrote:
> > I'm not sure if trapping the output of run_bzr is the best thing, but we
> > should start writing some interface tests that measure what the user is
> > actually seeing, so that we know our errors are being helpful.
> 
> I think we should trap the output of run_bzr, but I think we should add
> infrastructure to make it easy to check that the error matches a given
> regex.  (And yes, I think it's okay to require that the blackbox tests
> be run in English.)
> 
> e.g.
> 
> def run_bzr_error(self, error, *args, **kwargs):
>     stderr = self.run_bzr(retcode=3, *args, **kwargs)[1]
>     self.assertContainsRe(error, stderr)

+1

> > ------------------------------------------------------------------------
> > 
> > # Bazaar revision bundle v0.8
> > #
> 
> Err...

The bundle was empty.

-- 
Martin




More information about the bazaar mailing list