[bug] bzr commit with nothing changed fails with the wrong exception

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> I'm not sure if trapping the output of run_bzr is the best thing, but we
> should start writing some interface tests that measure what the user is
> actually seeing, so that we know our errors are being helpful.

I think we should trap the output of run_bzr, but I think we should add
infrastructure to make it easy to check that the error matches a given
regex.  (And yes, I think it's okay to require that the blackbox tests
be run in English.)

e.g.

def run_bzr_error(self, error, *args, **kwargs):
    stderr = self.run_bzr(retcode=3, *args, **kwargs)[1]
    self.assertContainsRe(error, stderr)
> ------------------------------------------------------------------------
> 
> # Bazaar revision bundle v0.8
> #

Err...

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEnBha0F+nu1YWqI0RAi9EAJ4ikZ/BJvGR9kgNwKEksC6rYu7dWgCdFTvp
iK+VsFBEQeo59SDf6HnPsDY=
=qf82
-----END PGP SIGNATURE-----