[MERGE] don't report malformed bundles as NotABundle

Aaron Bentley aaron.bentley at utoronto.ca
Wed Jun 21 17:39:56 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> 
> I don't think 'assertNotRaises' is really what we want.
> I think we want a fixed exception to be raised (MalformedBundle).

I think it's a bug in our implementation that crlf bundle cause
MalformedBundle to be raised.

> As far
> as the "doesn't raise anything" case, that is already handled by *not*
> catching the exception at all.

If we say 'assertRaises', it's a failure if it doesn't raise.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEmXZc0F+nu1YWqI0RAvlEAJ4wGcc/RVIB0QVXejSXKnZE+TkVBgCcD5qk
ROrcP3wdOFgPE+zgnVpuVeE=
=+EKg
-----END PGP SIGNATURE-----




More information about the bazaar mailing list