[MERGE] no-flicker progress bars

[Michael Ellerman]

On Tue, 2006-06-20 at 23:54 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Michael Ellerman wrote:
> > On 6/21/06, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Hi all,
> >>
> >> Here's a patch for progress bars that hides progress indicators until at
> >> least 1 second has passed.  This eliminates the flicker we've been
> >> seeing with that 'reading knit index' message, but works pretty well
> >> with longer operations like "merge", too.
> > 
> > On a related note, I think the progress phase stuff is a little
> > confusing. Because of the way the numbering is done, we often have the
> > progress bar sitting there saying "phase 0/x", which I think some
> > people might take to mean "nothing's happening yet". I think it'd be
> > better if it said "phase 1/x".
> 
> Yeah, I agree.
> 
> I feel like we're still feeling our way around with this progress stuff.
>  Another biggie is that showing "phase 1/x" instead of "fetching
> revision 234 of 563" isn't very helpful.  When I implemented overall
> progress, I wanted to make sure the bar was constant-width, and that was
> the only way that came to mind.

Cool, I'm not fussed about constant width, although I guess you don't
want it jumping around too much.

> What would you think of this?
> 
> 
> \ [==========                ] fetch revision 234 of 563 (33% overall)

I'd like that a lot.

I'm not sure how that would work for 1-step operations though, like
grabbing the inventory knit, where it's either not done or done. But I
think it'd still be an improvement, even if just for the revision
fetching stage.

The whole phase idea is a bit whack IMHO, in that for fetch we have four
phases, the relative durations of which are completely unknown, and yet
they occupy an equal amount of space on the progress bar.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060621/3651f498/attachment.pgp