[MERGE] no-flicker progress bars
aaron.bentley at utoronto.ca
Wed Jun 21 04:54:43 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Michael Ellerman wrote:
> On 6/21/06, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> Hi all,
>> Here's a patch for progress bars that hides progress indicators until at
>> least 1 second has passed. This eliminates the flicker we've been
>> seeing with that 'reading knit index' message, but works pretty well
>> with longer operations like "merge", too.
> On a related note, I think the progress phase stuff is a little
> confusing. Because of the way the numbering is done, we often have the
> progress bar sitting there saying "phase 0/x", which I think some
> people might take to mean "nothing's happening yet". I think it'd be
> better if it said "phase 1/x".
Yeah, I agree.
I feel like we're still feeling our way around with this progress stuff.
Another biggie is that showing "phase 1/x" instead of "fetching
revision 234 of 563" isn't very helpful. When I implemented overall
progress, I wanted to make sure the bar was constant-width, and that was
the only way that came to mind.
What would you think of this?
\ [========== ] fetch revision 234 of 563 (33% overall)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v188.8.131.52 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar