[RFC] bzr.jrydberg.get_versioned_file

Johan Rydberg jrydberg at gnu.org
Tue Jun 20 18:49:55 BST 2006


John Arbash Meinel <john at arbash-meinel.com> writes:

> So if I understand this correctly, you are just switching to
> VersionedFile which may not implement everything you need.
> Is that correct? 

Yes, that is correct.  

I do want to be able to fetch a per-file object from the repository,
but without going through a store.  Then if the object is a
VersionedFile or a RepositoryFile is arguable.  Aaron made a good
point that it is hard to determine if a method should be in RF or in
VF.

> I thought we wanted to change this line:
> +            already_present = bool([head for head in heads
> +                                    if version_id in head_ancestors[head]])

Done.

> Otherwise, I think getting rid of some parameters on
> InventoryEntry.find_heads() and adding find_heads() to VersionedFile is
> fine.

I have updated my branch with the change to the detection of known
heads.

~j





More information about the bazaar mailing list