[RFC] bzr.jrydberg.get_versioned_file

[John Arbash Meinel]

Johan Rydberg wrote:
> Aaron Bentley <aaron.bentley at utoronto.ca> writes:
> 
>>> OK.  I agree it might be better to keep VersionedFile as it is, and
>>> scrap RepositoryFile.  I would still like to see a get_versioned_file
>>> method in Repository.
>> Yes, I agree.  We have far too many 'get*weave*' calls in our code.
> 
> I have a branch available that implements get_versioned_file:
> 
> http://repo.panadafs.org/bzr/shared/bzr.jrydberg.get_versioned_file/
> 
> Also attaching a bundle (for easier review).
> 
> ~j
> 

So if I understand this correctly, you are just switching to
VersionedFile which may not implement everything you need.
Is that correct? The actual changes seem very similar, just without the
unused RepositoryFile class or function names.

I thought we wanted to change this line:
+            already_present = bool([head for head in heads
+                                    if version_id in head_ancestors[head]])

Otherwise, I think getting rid of some parameters on
InventoryEntry.find_heads() and adding find_heads() to VersionedFile is
fine.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060620/699474eb/attachment.pgp