[RFC] CURRENT_TREE_REVISION ?

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Fri, 2006-06-16 at 09:00 -0400, Aaron Bentley wrote:

>>I'm not sure current: is the clearest thing-- I immediately thought it
>>meant WorkingTree.last_revision().  Maybe 'directory:'?
> 
> 
> 'workingrevision:' along the lines of 'working tree' ? perhaps
> 'working:' to indicate its a revision in progress not a complete one.

I like 'working:'.

>>Bzr revert and shelve can use it to create bundles for the working tree
>>instead of backup files or patches.
> 
> 
> As long as we have the appropriate guards to ensure that these bundles
> can /never/ land in a repository, I'm happy with it being used for that.

Agreed.  In fact, I think we should add checks to the Repository API so
that it's impossible to install anything with the revision-id 'current:'
or 'null:'.

>>"bzr merge -r -1..revid:current: foo" can be used can be used to copy
>>uncommitted changes from foo.  (See also bzrtools shove, though.)
> 
> 
> also of use: 'bzr merge -r revid:current:'. Actually, I'd like to
> suggest that RevisionSpec barf on the literal value of the ID - I think
> this should be an internal symbol only. We can add a 'current:' or
> 'tree:' or other namespace qualifier directly to RevisionSpec without
> needing it to go through the revid: layer.

I should mention that I'm more and more convinced that RevisionSpec
should operate on trees, not branches, when it can.

> Well, I was meaning this api to return the objects, not the id. This
> would mean for instance that WorkingTree.revision_id would remain
> undefined - because 'current:' is not usable in Repository apis, so
> having it is not useful - but you can get the Revision object.

We've managed to avoid having a revision object for 'null:', why do we
want one for 'current:'?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEkrXJ0F+nu1YWqI0RAi26AJ44ZtuPhKWmMItk9daMditXCPz5bQCfbbPJ
g85kmVsiCZYDWZi3yFPznlE=
=G9eK
-----END PGP SIGNATURE-----