[MERGE REVIEW] Remove ConfigObj validation

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Martin Pool wrote:
> 
>>> +1 to having something like this added back in; it is useful in rare
>>> cases.  Perhaps 'run_bzr_subprocess' would be better?  I do think it
>>> should have a docstring:

I've submitted a version that changes the name, adds a docstring, and
uses sys.executable.

I haven't changed the retcode handling:
Currently, run_bzr_subprocess is variadic.  You can call it like this:
run_bzr_subprocess('merge', 'upstream', retcode=3)

If retcode becomes an explicit argument, then it becomes positional
(even if a default is supplied).  So it gets the value 'merge', which is
not desirable.

In order to make retcode explicit, we'd have to turn *args into a normal
argument, and call it like this:
run_bzr_subprocess(['merge', 'upstream'], retcode=3)

There's still the matter of shlex.  I'd prefer to keep it in, but I can
take it out if people insist.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEjI0s0F+nu1YWqI0RAqi6AJ9x//zrSL5gS/y7bBfT6lJ9oF9u8wCgiI3t
lKxTbtwRO4nYUj84+CmMcoA=
=U3n1
-----END PGP SIGNATURE-----