[BUNDLE] Give a revision-id to get_revision_delta.

[Robert Collins]

On Wed, 2006-06-07 at 18:08 +0100, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Johan Rydberg wrote:
> > Robert Collins <robertc at robertcollins.net> writes:
> > 
> >> On Wed, 2006-06-07 at 00:38 +0200, Johan Rydberg wrote:
> >>> The revno that Branch.get_revision_delta has been taking has been a
> >>> torn in my eye for a while now.  
> 
> > Also, should not the get_revision_delta method be a Repository method
> > instead of a Branch method?
> 
> IMHO, it's quite sane for Branch methods to take revnos, especially
> convenience methods like this one.  You've also changed the semantics
> slightly, because the leftmost parent may not be the mainline predecessor.
> 
> If you want to add a method to Repository instead of changing this one,
> that would be fine with me.

Given that we normalise history now, and are looking at removing the
revision-history file contents, is this much of an issue ? 

I agree about branch methods taking revno being fine though.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060608/53350ad8/attachment.pgp