[BUNDLE] Give a revision-id to get_revision_delta.

Aaron Bentley aaron.bentley at utoronto.ca
Wed Jun 7 18:08:32 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Johan Rydberg wrote:
> Robert Collins <robertc at robertcollins.net> writes:
> 
>> On Wed, 2006-06-07 at 00:38 +0200, Johan Rydberg wrote:
>>> The revno that Branch.get_revision_delta has been taking has been a
>>> torn in my eye for a while now.  

> Also, should not the get_revision_delta method be a Repository method
> instead of a Branch method?

IMHO, it's quite sane for Branch methods to take revnos, especially
convenience methods like this one.  You've also changed the semantics
slightly, because the leftmost parent may not be the mainline predecessor.

If you want to add a method to Repository instead of changing this one,
that would be fine with me.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEhwgQ0F+nu1YWqI0RAgDCAJ9O/6kbInX+1gU9XD3Yxhk1jvUu9QCffGXA
EnyLVMGbR0WrZbcPd3EYUOE=
=sZfv
-----END PGP SIGNATURE-----




More information about the bazaar mailing list