[MERGE REVIEW] Performance tweak for TreeTransform

John A Meinel john at arbash-meinel.com
Thu May 25 05:10:58 BST 2006


Aaron Bentley wrote:
> John Arbash Meinel wrote:
> 
> | The code looks pretty good. Do you have a branch of this somewhere?
> 
> Sure: http://code.aaronbentley.com/bzr/bzrrepo/bzr.ttransform/
> 

Are you sure, the last revision I see there is:
 1507 Aaron Bentley     2006-04-10
      Fixed backup numbering to match GNU standard better


> | I assume that the cache only lasts as long as the Transform object,
> right?
> 
> Right, and the WorkingTree is locked for the lifetime of the Transform.
> 
> | This doesn't seem to effect the time to build a tree, (at least by my
> | measured times for bzr branch). So what does this effect?
> 
> It affects the bzrtools import plugin, and anything that calls
> TreeTransform.trans_id_tree_path or TreeTransform.trans_id_file_id a
> lot.  So it also should affect revert and merge, but not build_tree.
> 

Well, I did some testing with revert, and it does indeed cut the time by
as much as 1/2. (2.55s versus 1.38s).


> | Is it the
> | commit time, or the add time? I'm not sure what you mean by "import
> speed".
> 
> The time to execute "bzr import linux-2.6.16.tar.bz2 linux"
> 
> Aaron

So, after all, good enough to merge. Even better if you add a benchmark
test.
John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060524/cc5c3c73/attachment.pgp 


More information about the bazaar mailing list