[MERGE REVIEW] Performance tweak for TreeTransform

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:

| The code looks pretty good. Do you have a branch of this somewhere?

Sure: http://code.aaronbentley.com/bzr/bzrrepo/bzr.ttransform/

| I assume that the cache only lasts as long as the Transform object, right?

Right, and the WorkingTree is locked for the lifetime of the Transform.

| This doesn't seem to effect the time to build a tree, (at least by my
| measured times for bzr branch). So what does this effect?

It affects the bzrtools import plugin, and anything that calls
TreeTransform.trans_id_tree_path or TreeTransform.trans_id_file_id a
lot.  So it also should affect revert and merge, but not build_tree.

| Is it the
| commit time, or the add time? I'm not sure what you mean by "import
speed".

The time to execute "bzr import linux-2.6.16.tar.bz2 linux"

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEdQQm0F+nu1YWqI0RAscuAJ98eA+B++66zKpWkZe1zi1i/BzcrQCeJ/C9
XibuGRC8BRZjKwyGGbeijow=
=RE2s
-----END PGP SIGNATURE-----