Changesets feature complete

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
| On 20 May 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
|
|
|>>This is by design.  'Changeset' is a really bad word to describe what
|>>these things have become-- they're more like a collection of revisions
|>>in a textual format.
|
|
| I agree; it's used for too many things.
|
| "Change pack", "patchset", "change bundle", ...?

More: Branch bundle, repository fragment, repo shard.

| But we also want the posted thing to be suitable for code review, which
| usually wants a single diff spanning the whole thing.
|
| So in some cases I think we will want *both* the overall and individual
| diffs

We do this by default.  I've attached an example.

In the example, the first diff (Test and fix...) is against the
changeset base, which defaults to the common ancestor.  All subsequent
diffs are against the rightmost parent.  Since the third revision (Merge
mainline) produced a tree that was identical to its rightmost parent, it
has no actual diff.

| possibly with the individual diffs packed up (e.g. in a
| zip mime attachment) so they don't clutter up the review.
|
This is something we haven't done.  It's worth considering.  It can be
interesting to page through the various diffs to see the evolution of
the patch, but people are sometimes embarassed by that.  They prefer to
provide a final, cleaned-up patch that doesn't show the missteps along
the way.

On the other hand, it's hard to know how a changeset that was largely
opaque would be received on MLs like the lkml.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEc9uh0F+nu1YWqI0RAijOAJ9kHZ/wsgz3Be2lleOhp/NsWXPHuQCfVt2L
ExAhyNmWoLMgKBguSKBYSVM=
=sfHF
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: transform.patch
Type: text/x-patch
Size: 5389 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060524/d7743d26/attachment.bin