[merge] FTP now has and passes regression tests

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>>I've managed to cut down medusa to a 105K ftp server, and integrated it
>>into bzrlib/util.  Branch is here:

> I think if we do it that way, we could also take some time and clean
> things up.

Yes, this was a hack job.

> First off, they use 'counter' because they don't want to worry about
> overflow. 

> I don't know when python decided to do automatic upcasting, but
> certainly 2.4 has it.

True.

> Second, the ftp_channel built into medusa doesn't support append or
> rename.

Heh, so you had to add support for the append command on the server
before we could test it on the client?

> I suppose we could just propose some patches and get amk to incorporate
> them.

The second definitely sounds worthwile.  I can imagine AMK might want to
preserve lots of backwards compatibility.

> What I would really like to see is a semi-official bzr branch of the
> original medusa, and then we merge it into bzr and remove the
> unnecessary files. (By-value nested tree).

I considered doing something like that with the version.  The thing
about that is, the full tree takes a lot of space in the repo.  So the
bzr repository would be ~ 800K larger if we pulled in the whole history.
 Which seemed like a lot to pay for a bunch of files we don't want to use.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEa2kY0F+nu1YWqI0RAnD5AJwIw0eyuOee7qjwYHHCr4KPAJXgpwCeOlD9
fCorLOe2lRabV709p/F2DyE=
=l7MU
-----END PGP SIGNATURE-----