[PATCH] knit pushing with ftp transport

[John Arbash Meinel]

Alexandre Saint wrote:

...

>> I do believe warning() should be done the same:
>> warning("FTP temporary error: %s. Retrying.", str(e))
>>
>> This is a small performance issue. Technically mutter() may not do
>> anything if the debug level isn't low enough. And in that case it
>> doesn't need to take the time to format the string, also it helps to
>> catch UnicodeErrors, since they happen inside mutter() instead of inside
>> your own code.
>>
> 
> Adapted all mutter() and warning() calls throughout ftp.py, in this patch.
> 
>> +1 with a couple of fixes. Someone else needs to review it before it can
>> be merged, and somehow I managed to upset the pqm so it isn't able to
>> merge from me right now. So someone else needs to submit it anyway.
>>
>> John
>> =:->
>>
> 
> Thanks, John :).
> 
> So seeking +1 from other people, now. :)
> 
> Regards,


I went ahead and applied this patch to my ftp_server branch at:
http://bzr.arbash-meinel.com/branches/bzr/ftp_server

Which also includes some support for using medusa to have an ftp server,
so that ftp actually gets tests. After I get the tests passing, I'll
post the changes for review, and hopefully we'll get it into bzr core.
(Hopefully for 0.8.1).

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060516/90c87cdc/attachment.pgp