[PATCH] use "! /usr/bin/env python" in generate_docs.py

Robert Widhopf-Fenk hack at robf.de
Wed May 10 23:32:39 BST 2006


On Tuesday, May 9, 2006 at 21:04:35, Aaron Bentley wrote:
> Robert Widhopf-Fenk wrote:
> > But now you can "ln -s `which python2.4` ~/bin",
> > i.e. you may control which version is called by
> > modifying PATH and/or setting symlinks.
> 
> Doesn't it seem a bit much to make the user do that?  What if they
> want Python2.5 by default, but generate_docs is incompatible with
> it?

Reading this I think it would have helped me more if the
version would have been checked and an version mismatch
error would have been signaled instead of

,----
|     @deprecated_function(zero_seven)
|     ^
| SyntaxError: invalid syntax
`----

> > Adding the code in bzr.dev/bzr which "searches" for a 2.4
> > version would have been overkill for me. 
> 
> I can see that, but on the other hand, it means that generate_docs
> will fail on more systems than bzr will fail on, even though they
> have the same requirement for python2.4.
> 
> Perhaps that's acceptable, since generate_docs isn't as critical as
> bzr, but personally, I'd rather do /usr/bin/env python2.4 on both of
> them.

In deed it would make the requirement instantly visible, so
I also would prefer "#! /usr/bin/env python2.4".

 Robert




More information about the bazaar mailing list