Test spends too long in wait()

[Robert Collins]

On Thu, 2006-04-27 at 11:41 +1000, Martin Pool wrote:
> On 27/04/2006, at 8:42 AM, John Arbash Meinel wrote:
> 
> > When running bzr selftest, I found that:
> > TransportImplementation.test_connection_error(SFTPHomeDirServer)
> >
> > Will SKIP, and report that it only takes 1ms to run. But really it  
> > hangs
> > for a fairly long time (~5s).
> >
> > If you ^C while it is hanging it shows that it is in wait() status.
> >
> > So I'm thinking it is an issue that raising TestSkipped() in an SFTP
> > tests never tells the server thread to exit.
> > I'm not sure what the best method to fix this is.
> >
> > Would it be better if cleanup code was called even if the test was
> > skipped? (I'm assuming that is where the server is told to shutdown).
> 
> Yes, the cleanup code should be called if the test is skipped - is  
> that not happening?

The 5s timeout is in the cleanup code.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060427/c2aa4127/attachment.pgp