Test spends too long in wait()

[Martin Pool]

On 27/04/2006, at 8:42 AM, John Arbash Meinel wrote:

> When running bzr selftest, I found that:
> TransportImplementation.test_connection_error(SFTPHomeDirServer)
>
> Will SKIP, and report that it only takes 1ms to run. But really it  
> hangs
> for a fairly long time (~5s).
>
> If you ^C while it is hanging it shows that it is in wait() status.
>
> So I'm thinking it is an issue that raising TestSkipped() in an SFTP
> tests never tells the server thread to exit.
> I'm not sure what the best method to fix this is.
>
> Would it be better if cleanup code was called even if the test was
> skipped? (I'm assuming that is where the server is told to shutdown).

Yes, the cleanup code should be called if the test is skipped - is  
that not happening?

-- 
Martin