[MERGE] pybaz: sanitize patch logs for more tla quirks

Robert Collins robertc at robertcollins.net
Tue Apr 25 22:30:58 BST 2006


On Tue, 2006-04-25 at 14:56 +0200, David Allouche wrote:
> On Tue, 2006-04-25 at 20:26 +1000, Anand Kumria wrote:
> > I think this is a highly complex solution that isn't neccessary.
> 
> I agree, that's annoyingly complex (esp. since I'm going to have to
> implement it) but I cannot think of anything simpler that is still
> correct.
> 
> Something simpler could addresses all my non-regression concerns: just
> ignore invalid headers.
> 
> Independently, raise on multiple matching headers because we cannot
> decide what to return, and it's critical to bzr data consistency to be
> consistent with what other baz-import runs would have produced.
> 
> Robert how does that one sound to you?

I don't think we should raise on dups: rather check the tla code to see
which one it honours when reading the logs, and use that logic.

IIRC its a loop from top to bottom over the headers inserting into a
hash table. I think it takes the last one always, so duplicating that
will work no worse than arch.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060426/ec736a08/attachment.pgp 


More information about the bazaar mailing list