[merge] updated store-escaping for windows

[Martin Pool]

On 12/04/2006, at 2:39 PM, Robert Collins wrote:

> On Tue, 2006-04-11 at 18:57 +1000, Martin Pool wrote:
>> This change, based on John's previous work, changes Knit stores to  
>> avoid
>> characters in filenames that can't be safely stored on Windows.
>> (Basically everything but lowercase letters, digits, and a few
>> punctuation characters.)
>>
>> - Add a FakeVFAT transport decorator that lets us check some of these
>>   constraints.  (Eventually it might be nice to be able to run
>>   WorkingTree tests through this too to trap Windows-specific bugs
>>   even when testing on Unix.)
>>
>> - Add an 'escaped' parameter to the TransportStore.
>
> Some feedback
>
> the propogation of _cloning in some function calls is undesirable -  
> that
> was a hack to allow the legacy formats - the non metadir ones - to
> privately signal that they did not need to create their data  
> structures.
> Certainly it shouldn't be part of the public api.

OK, this additional change confines it to the classes which need it:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20060412-cleanup-cloning.diff
Type: application/octet-stream
Size: 4118 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060412/63e1034c/attachment.obj 
-------------- next part --------------

-- 
Martin