[MERGE] fix relpath calls at '/'

Robert Collins robertc at robertcollins.net
Wed Apr 5 01:13:43 BST 2006


On Tue, 2006-04-04 at 08:12 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> 
> | +    assert len(base), 'Length of base must be > 1 (to start with /).'
> 
> Code doesn't match text.  Would be better as
> 
> ~    assert len(base) > 0, 'Length of base must be > 0 (to start with /).'
> 
> (and on Windows, the shortest absolute path is 3 letters.)

I'll add a os check there and assert for >0 and > 2 then, with a comment
that the base is shorter than the shortest absolute path.

> I also wonder whether ensuring netloc couldn't happen when registering
> protocols.

I don't think so - not all out registered protocols use urlparse, and
several (the decorators) are not even protocols - they are prefixes.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060405/928ea310/attachment.pgp 


More information about the bazaar mailing list