[PATCH] mv command takes over

Martin Pool mbp at sourcefrog.net
Thu Mar 9 03:33:37 GMT 2006


On 9 Mar 2006, at 13:32 , Matthew D. Fuller wrote:

> On Thu, Mar 09, 2006 at 01:17:22PM +1100 I heard the voice of
> Martin Pool, and lo! it spake thus:
>>
>> Does this pass all the existing tests?  (It probably does; I'm just
>> checking.)
>
> Well, I'm not really sure how to interpret the selftest output...
>
> -----------------------
> [...]
> ERROR: test_build (bzrlib.tests.test_setup.TestSetup)
> [...]
> FAIL: test_build (bzrlib.tests.test_setup.TestSetup)
> [...]
>
> Ran 1766 tests in 505.848s
>
> FAILED (failures=1, errors=1)
> tests failed
> -----------------------
>
>
> Those seem to be the appropriate bits...   so I think it doesn't cause
> any problems, since that test is just something testing setup.py?

Yes, I think that was the recently reported bug in there, which  
should be merged shortly if it's not already.  So your change should  
be fine to come in.

If you're feeling keen to fix things like this (and I hope you  
are :-) you could try making sure that 'bzr rm foo' both removes foo  
from the working directory, as well as making it unversioned.  This  
will need a new test in blackbox, which should be easy to crib from  
the existing code.

-- 
Martin Pool







More information about the bazaar mailing list