[MERGE] nested-progress-bar api

[Robert Collins]

On Tue, 2006-03-07 at 10:27 -0800, Robey Pointer wrote:
> On 7 Mar 2006, at 6:59, Aaron Bentley wrote:
> 
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Robert Collins wrote:
> >> This adds the nested progress bar api and converts the existing  
> >> code to
> >> use nested_progress_bar everywhere that a progress bar was being
> >> created, and to release them.
> >
> 
> One tiny nit in addition to Aaron's comments:
> 
> > @@ -75,7 +75,8 @@
> >                   show_eta=True,
> >                   show_bar=True,
> >                   show_count=True,
> > -                 to_messages_file=sys.stdout):
> > +                 to_messages_file=sys.stdout,
> > +                 klass=None):
> >          """Setup the stack with the parameters the progress bars  
> > should have."""
> >          self._to_file = to_file
> >          self._show_pct = show_pct
> 
> Python style for "it's not a keyword!" class params is usually "cls"  
> so I'd like that for consistency.  (I told you it was a nit.) :)
> 
> Otherwise I'm +1.

Thanks. We use klass elsewhere, so for consistency with bzr I'm going to
go with klass for now - we can decide on a bzr project standard
later :).

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060308/b0884517/attachment.pgp