[MERGE] nested-progress-bar api

Robey Pointer robey at lag.net
Tue Mar 7 18:27:50 GMT 2006


On 7 Mar 2006, at 6:59, Aaron Bentley wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins wrote:
>> This adds the nested progress bar api and converts the existing  
>> code to
>> use nested_progress_bar everywhere that a progress bar was being
>> created, and to release them.
>

One tiny nit in addition to Aaron's comments:

> @@ -75,7 +75,8 @@
>                   show_eta=True,
>                   show_bar=True,
>                   show_count=True,
> -                 to_messages_file=sys.stdout):
> +                 to_messages_file=sys.stdout,
> +                 klass=None):
>          """Setup the stack with the parameters the progress bars  
> should have."""
>          self._to_file = to_file
>          self._show_pct = show_pct

Python style for "it's not a keyword!" class params is usually "cls"  
so I'd like that for consistency.  (I told you it was a nit.) :)

Otherwise I'm +1.

robey





More information about the bazaar mailing list