auto guess committer email.. good idea?

Erik Bågfors zindar at gmail.com
Thu Mar 2 08:37:06 GMT 2006


2006/3/2, Martin Pool <mbp at sourcefrog.net>:
> On 28 Feb 2006, Erik Bågfors <zindar at gmail.com> wrote:
> > 2006/2/28, James Blackwell <jblack at merconline.com>:
>
> > > I think that there's four, ordered by the ways I think are easiest for
> > > users.
> > >
> > >  1. Leave it alone.
> > >  2. Politely remind user that email address isn't open.
> > >  3. Ask for the email address
> > >  4. Bomb out if email address isn't set
> >
> > As a user, I'd order it 2, 4, 3, 1.
>
> There are a few levels of "set" or not - if $MAIL is set, it's probably
> a reasonable assumption and doesn't require a warning.  If /etc/mailname
> is present (giving the machine's mail domain) is that good enough?
> Probably so.  (Separately - is there any good equivalent accessible from
> Python on Windows?)
>
> If none of these and we are just going to use user at hostname with the raw
> hostname then a warning shown once per process would be OK with me

+1

/Erik




More information about the bazaar mailing list