Lobbying for -p1 diffs

Martin Pool mbp at sourcefrog.net
Thu Mar 2 05:43:36 GMT 2006


On  2 Mar 2006, Andrew Bennetts <andrew at canonical.com> wrote:

> Defaulting to -p1 will make my life marginally harder.  I do a lot of code
> reviews of Launchpad code, based on the output of bzr diff.  I regularly want to
> copy-and-paste the paths from diffs into emails (to say "in foo/bar/baz.py, xyz
> seems wrong.") and into my editor to open up files for more context than the
> diffs show me.
> 
> Prefixes like orig/ and mod/ make this a little bit inconvenient.

And slightly more so if the prefixes aren't just that but change from
one run to another (useful though that might be in other ways).

Given Matthew's point about patch swallowing -p0 patches more easily
than -p1, I propose that we keep the default behaviour the same but make
say 'bzr diff -p' do that style.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060302/7fe5967b/attachment.pgp 


More information about the bazaar mailing list