Lobbying for -p1 diffs

[Andrew Bennetts]

Robert Collins wrote:
> On Wed, 2006-03-01 at 17:23 -0600, Matthew D. Fuller wrote:
[...]
> > And more immediately,
> > 
> > - 95% or better of my use of diff isn't intended for patch, it's
> >   intended for my eyes.  Having those extra dirs there means I need to
> >   stop, and carefully read and interpret those lines to figure out
> >   what they mean, instead of just a quick glance to tell me where I
> >   am.
> 
> Thats more of a concern. I'm not sure of the impact though, I've never
> had a problem with orig/ and mod/ prefixes in other systems.

Defaulting to -p1 will make my life marginally harder.  I do a lot of code
reviews of Launchpad code, based on the output of bzr diff.  I regularly want to
copy-and-paste the paths from diffs into emails (to say "in foo/bar/baz.py, xyz
seems wrong.") and into my editor to open up files for more context than the
diffs show me.

Prefixes like orig/ and mod/ make this a little bit inconvenient.

Hardly earth-shattering, but FWIW I'm slightly happier without -p1 diffs :)

-Andrew.