auto guess committer email.. good idea?

[Erik Bågfors]

2006/2/28, James Blackwell <jblack at merconline.com>:
> On Tue, Feb 28, 2006 at 03:07:43PM +0100, Erik Bågfors wrote:
> > Hi
> >
> > I'm not a big fan of the fact that bzr tries to guess the committer
> > email. I think lot's of people will commit with "Foo Bar
> > <foo at hostname>"... and that's most likely not what they want.
>
> As somebody else mentioned, I think this was brought up in the past.  I'm
> for keeping the current behaviour. The current behaviour means that no
> installation is required in order to get started.
>
> Its kind of cool that somebody can start using bzr today without having to
> go through any setup investment. Sure, that means that the earlier
> revisions for someone are going to have things like "Owner at nibbles".
> Though people later fix their email address for newer revisions, I haven't
> detected any sort of stress when it comes to the stored email address for
> older revisions.
>
> > I see two choices.  Give a message saying "you have not set your email
> > address, set it like this: <explanation>".... or do what darcs does
> > and ask.
>
> I think that there's four, ordered by the ways I think are easiest for
> users.
>
>  1. Leave it alone.
>  2. Politely remind user that email address isn't open.
>  3. Ask for the email address
>  4. Bomb out if email address isn't set

As a user, I'd order it 2, 4, 3, 1.

/Erik