plugin names

[Robert Collins]

On Wed, 2006-02-22 at 08:05 -0600, John Arbash Meinel wrote:
> Martin Pool wrote:
> > On 22 Feb 2006, Robert Collins <robertc at robertcollins.net> wrote:
> >> python limits module names to something approximately like
> >> [a-zA-Z_][a-zA-Z0-9_]*
> >>
> >> Perhaps we should not load plugins that dont meet the python module name
> >> criteria, so that bzrlib.plugins.* only contains valid python module
> >> names?
> > 
> > That would be OK, though might break some people who have checkouts in
> > their plugin directory called say 'gannotate.mbp'.
> > 
> 
> I don't really see why. It is actually possible to use any name using
> 'getattr' and 'setattr'.
> You can do:

Because if I in another plugin want to access an illegally named plugin
its unpleasant to have to use gettattr.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060223/69d6318f/attachment.pgp