Tree Transform passing all tests, plus abuse

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
|>Okay: how about
|>
|>get_id_tree      -> trans_id_tree_file_id
|>get_trans_id     -> trans_id_file_id
|>get_tree_path_id -> trans_id_tree_path
|>get_tree_file_id -> tree_file_id
|>final_file_id    -> final_file_id (unchanged)
|>inactive_file_id -> inactive_file_id (unchanged)
|>
|>I haven't done this yet, but what do you think?
|
|
| I feel like we need some sort of 'from' in there. like
| 'trans_id_from_tree_file_id'.

That's quite a lengthy function name, which was why I wasn't putting
'from' in there.

Though it still isn't obvious what the
| difference is between 'trans_id_tree_file_id' and 'trans_id_file_id'.

trans_id_tree_file_id returns the trans_id of the file that has the
specified file_id in the tree.  After the transform is applied, a
different trans_id may be associated with the file_id.

trans_id_file_id returns the trans_id currently associated with the
file_id, if there is one.  If not, it invents a trans_id, and associates
it with the file_id.

| I also don't need the commands to be fully self documenting either.
|
| What is the specific difference between the two above, and why can't we
| just have a 'get_trans_id' which takes a file id, and returns a
| transaction id.

Sometimes we want to refer to the tree file ids, specifically, sometimes
we just care about the final file ids.  I think there's no getting
around it.

| Or maybe something like
|
| get_tree_file_id => file_id_of()

That would be wrong, because tree_file_id is not the same as final_file_id.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD932U0F+nu1YWqI0RAoiVAJ9FCA0xr/JHvjOxz7ghfIYrG5nuaACeNDnT
/zN4f6u9pvlId7gQAweS/LM=
=V+Hj
-----END PGP SIGNATURE-----