Selftest kipple

Martin Pool mbp at sourcefrog.net
Thu Feb 2 02:32:52 GMT 2006


On  1 Feb 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> The selftests are overflowing with kipple, and it's making them very
> hard for me to use.  Line after line of
> 
> lock read: <bzrlib.lockable_files.LockableFiles object at 0xb4b1b78c> (4)
> unlock: <bzrlib.lockable_files.LockableFiles object at 0xb4b1b78c> (5)

Perhaps those should be commented out, except for when people are
specifically debugging locks?

> FIXME: clone via create and fetch is probably faster when versioned file
> comes in.

I don't think there's much point emitting FIXME messages to stdout from
test cases.  We don't do it from regular code unless it's a warning that
the user really needs to know about.  The test suite *is* something that
users will run and so ought to look tidy.  So I think the right place
for those things is either bug records, fixme comments, or tests that
report being skipped.

> Plus various testcases that are noisily commented-out.

We should change them to properly indicate that they're skipped; I'll do
that.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060202/b8d65e19/attachment.pgp 


More information about the bazaar mailing list