Weave.join(), and pr."ogress indicator fixes

[John Arbash Meinel]

Robey Pointer wrote:
> 
> On 27 Jan 2006, at 19:43, John A Meinel wrote:
> 

...

> * I caught the progress bar saying "merge weave merge" at one point.  It
> isn't part of your patch, but sometime that should probably be changed
> to a meaningful phrase.

What about 'merging weaves'?

> 
> * There's still a long pause between the last progress bar and "All
> changes applied successfully."  I don't know why, maybe just my slow
> computer.

As near as I can tell, this is the time it is actually merging the
changes onto the disk. How long is a long pause? Minutes, seconds? I see
maybe <5s on my slower machine.

I would like it to be faster, but I'm not sure where the code should lie.

> 
> * You no longer need the [brackets] in this line in python 2.4:
>     n1 = set([self._names[i] for i in self_parents])
>   :)

General question, do we want to use the new generator syntax?
The above creates a list, which is passed to set(), Robey's suggestion
would create a generator.

> 
> It did a lot better at showing status during the merge though, so I'm +1
> on the concept, even if I can't really judge the weave fix.
> 
> robey
> 

Thanks. I did go ahead and merge the code so far, because I think it is
important to get that fix in. But I'm willing to add a couple more fixes
while we are looking at this code.

John
=:->



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060129/d97b8c1b/attachment.pgp