Encoding branch and globs (Was: Re: [ANN] ezbzr 0.2)

[John A Meinel]

Jan Hudec wrote:
> On Fri, Jan 27, 2006 at 13:13:00 -0600, John A Meinel wrote:
>> Jan Hudec wrote:
>>> I have looked at the encoding branch and noticed that it includes a glob
>>> matcher, mostly stolen from fnmatch module, but slightly incompatible in that
>>> it that it makes ** match including / and * match except /.
>> Actually, I implemented mine about 2 days before you did yours :)
>> I like yours more, and was planning on deleting glob_matcher.py at the
>> appropriate time.
> 
> Ok. It will take few more days for porting the other users and then another
> review on the list.
> 

...

>> I would like to see Windows use your advanced globbing patterns.
> 
> Ok. I'll try to get it into the mainline. It should not need anything else
> from your branch.
> 
>> Reading over the mailing list, I didn't see any specific problems with
>> integrating your bzr.ignore branch. Do you have a list of issues before
>> I could pull it into jam-integration? I suppose I could give it another
>> quick review.
> 
> Well, there is this
> http://article.gmane.org/gmane.comp.version-control.bazaar-ng.general/7702
> post from Robert Collins. There is no real final word in the thread.
> 

I remember that now. And I did want to comment on it.

Specifically, we do need a marker to indicate that we are using an old
versus a new .bzrignore.

The reason is that for old revisions, we included the built-in entries.
While in the future, we are going to write all the built-in ones into
.bzrignore, and then not use the builtin ones.

I'm not very concerned about the tiny semantic difference between your
glob matcher and the current one. I am concerned that when we stop using
built-in globs, all old revisions will show up with tons of '.pyc' files
that aren't considered ignored.

I don't know that it should block getting the new glob matcher into bzr,
but we definitely need to worry about it when we change how we handle
.bzrignore.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060127/043c235f/attachment.pgp