Encoding branch and globs (Was: Re: [ANN] ezbzr 0.2)

[Jan Hudec]

On Fri, Jan 27, 2006 at 13:13:00 -0600, John A Meinel wrote:
> Jan Hudec wrote:
> > I have looked at the encoding branch and noticed that it includes a glob
> > matcher, mostly stolen from fnmatch module, but slightly incompatible in that
> > it that it makes ** match including / and * match except /.
> 
> Actually, I implemented mine about 2 days before you did yours :)
> I like yours more, and was planning on deleting glob_matcher.py at the
> appropriate time.

Ok. It will take few more days for porting the other users and then another
review on the list.

> > I have here another implementation of globs, that mimics shell behaviour much
> > closer. It also uses unicode objects instead of strings everywhere, to be
> > sure it won't attempt to convert to string anywhere (because that'd blow up,
> > given that we read .bzrignore as utf-8). Besides that I have already updated
> > WorkingTree to use my new matcher. I now want to port per-branch
> > configuration and glob expansion on Windows too.
> > 
> > My branch is http://drak.ucw.cz/~bulb/bzr/bzr.ignore
> > I can rebase it on your branch or create a combined branch with conflicts
> > resolved if you want to use it.
> 
> I'm guessing that yours will be merged into mainline, and I'll pull it
> from there. I'm actually thinking to delete all those files, because the
> only thing I *truly* need is for .bzrignore to be decode('utf-8'). Then
> I can get your advanced globbing along with everyone else.
> 
> I would like to see Windows use your advanced globbing patterns.

Ok. I'll try to get it into the mainline. It should not need anything else
from your branch.

> Reading over the mailing list, I didn't see any specific problems with
> integrating your bzr.ignore branch. Do you have a list of issues before
> I could pull it into jam-integration? I suppose I could give it another
> quick review.

Well, there is this
http://article.gmane.org/gmane.comp.version-control.bazaar-ng.general/7702
post from Robert Collins. There is no real final word in the thread.

-- 
						 Jan 'Bulb' Hudec <bulb at ucw.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060127/464c51a6/attachment.pgp