Encoding branch and globs (Was: Re: [ANN] ezbzr 0.2)

[Jan Hudec]

On Thu, Jan 26, 2006 at 08:00:24 -0600, John A Meinel wrote:
> Robey Pointer wrote:
> > How ready is your encoding branch?  Need a review? :)
> 
> If you want to review its current state, I would be very happy. I just
> want to make sure I'm not going off on a tangent that people won't like.
> 
> It isn't complete. It was 50-75% done on updating the commands, when I
> ran into the bzrignore problem (we weren't reading .bzrignore as utf-8,
> though I thought fnmatch just wasn't handling unicode characters). And
> then I ran into the problem that on Mac OSX it normalizes filenames.
> 
> So if I'm dealing with all of that, I'm maybe 40% done. But it would be
> nice to have someone give feedback about the design itself.

I have looked at the encoding branch and noticed that it includes a glob
matcher, mostly stolen from fnmatch module, but slightly incompatible in that
it that it makes ** match including / and * match except /.

I have here another implementation of globs, that mimics shell behaviour much
closer. It also uses unicode objects instead of strings everywhere, to be
sure it won't attempt to convert to string anywhere (because that'd blow up,
given that we read .bzrignore as utf-8). Besides that I have already updated
WorkingTree to use my new matcher. I now want to port per-branch
configuration and glob expansion on Windows too.

My branch is http://drak.ucw.cz/~bulb/bzr/bzr.ignore
I can rebase it on your branch or create a combined branch with conflicts
resolved if you want to use it.

-- 
						 Jan 'Bulb' Hudec <bulb at ucw.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060127/8b38fb81/attachment.pgp