[rfc][patch] test-providers branch ready for merge

[Robert Collins]

On Tue, 2006-01-10 at 08:15 -0600, John Arbash Meinel wrote:
> > --- bzrlib/branch.py	
> > +++ bzrlib/branch.py	
> > @@ -155,7 +155,7 @@
> >  
> >      def _get_nick(self):
> >          cfg = self.tree_config()
> > -        return cfg.get_option(u"nickname", default=self.base.split('/')[-1])
> > +        return cfg.get_option(u"nickname", default=self.base.split('/')[-2])
> >  
> >      def _set_nick(self, nick):
> >          cfg = self.tree_config()
> > 
> 
> What is this supposed to be doing? Is it just that now you have having
>'self.base' default to ending with a slash?

Not default to, forced to.

> Is there a particular rationale for that?

Yes, before we actually had some transports ending in / and some not. So
various places had waiting-for-accidents. bzr info http://.../foo and
bzr info http://.../foo/ would behave differently. 

> So, +1 with the small question as to why you are having all paths end in
> a slash.

Two reasons - I wanted to make it consistent so that we didn't have the
opportunity for similar inconsistency to arise; transports connect to
directories, its a nice little visual hint to have the base dir have a
'/' at the end.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060111/a886c409/attachment.pgp