[rfc][patch] test-providers branch ready for merge

John Arbash Meinel john at arbash-meinel.com
Tue Jan 10 14:15:31 GMT 2006


Robert Collins wrote:
> http://people.ubuntu.com/~robertc/baz2.0/test-providers
> 
> Cheers,
> Rob
> 
> 

...

> === modified file 'bzrlib/branch.py'
> --- bzrlib/branch.py	
> +++ bzrlib/branch.py	
> @@ -155,7 +155,7 @@
>  
>      def _get_nick(self):
>          cfg = self.tree_config()
> -        return cfg.get_option(u"nickname", default=self.base.split('/')[-1])
> +        return cfg.get_option(u"nickname", default=self.base.split('/')[-2])
>  
>      def _set_nick(self, nick):
>          cfg = self.tree_config()
> 

What is this supposed to be doing? Is it just that now you have having
'self.base' default to ending with a slash?

Is there a particular rationale for that?

So, +1 with the small question as to why you are having all paths end in
a slash.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060110/adf5b954/attachment.pgp 


More information about the bazaar mailing list