moving branch nick recording out of Commit, into WorkingTree

[Robert Collins]

On Mon, 2006-01-09 at 01:13 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> | It should be possible to record commits with no branch nickname - not an
> | empty one, a non existent one.
> 
> I'm not sure I agree.  Could you expand on why?

Well for the baz2bzr case, we can talk below. PQM is another case - it
branches from a branch to make a branch to test and commit to and then
pushes that back up. the path it branches to is a tempfile name, so the
dir name is a bad heuristic; branch nicks are not copied by clone
(IIRC). I can fix that by patching PQM - in fact I will... but it seems
to me that nicks are an optional feature - and at the moment they are
compulsory. If they are compulsory then I dont think nick should be a
revision property, it should be a core feature.

> | I think the easiest way is to think of recording the nick as policy and
> | move it up to the WorkingTree commit wrapper. Then tools like baz2bzr
> | that both have no nickname and no good way to set it can commit without
> | one by creating a Commit() object directly.
> 
> Why is setting it on the branch not a good way to set it?

Setting it on the branch is fine, but baz2bzr does not give the user
time to set it - it creates the branch and then goes hell for leather.

> Wouldn't the arch version be a great branch nick?

Possibly, which is a somewhat orthogonal discussion. I dont think its a
great nick because of the while namespace problems in arch - the
username is preserved in author, so the archive part is not terribly
useful, the category is - but we dont seem to put category or an
analagous thing in branch nicks today, the version field is often 0 for
many users, and the branch name - well when its present we could use
that I guess.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060109/4a540df8/attachment.pgp