[RFC] more encodings tests [was: bzr handles unicode]

Alexander Belchenko bialix at ukr.net
Fri Jan 6 22:35:51 GMT 2006


John Arbash Meinel пишет:
> I have a branch available here:
> http://bzr.arbash-meinel.com/branches/bzr/encoding/

John, I'm currently work with your branch. Here some patches for r1527:

test_non_ascii.diff -- little fix for work in process
msgeditor.py -- added errno code for win32 permission denied error

And most important:

test_log.diff -- I've add my test for checking different encodings of 
log command output. It was surprising to me but this test was fail. But 
when I run manually python bzr log from command line I see that bzr 
works correct. I don't understand what wrong with my test. Probably 
there is some side effect of wrapping wrapped dummy sys.stdout stream?

Or may be my test is unnecessary because your tests already cover my case?

And there is one more bug in test_non_ascii.py : test_log test. This 
test skipped on my win32 box 'cause cp1251 cannot represent name of Erik 
  Bågfors. But when selftest do final cleanup of temp directory of this 
test there is permission denied error raised. It means that some files 
in this dir is not closed. (Yeah, I know, bad windows cannot unlink file 
currently in use). I don't dig into this problem yet.

--
Alexander
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: msgeditor.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060107/c988a5c5/attachment.diff 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: test_log.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060107/c988a5c5/attachment-0001.diff 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: test_non_ascii.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060107/c988a5c5/attachment-0002.diff 


More information about the bazaar mailing list