bazaar web interface

[Robert Collins]

On Wed, 2006-01-04 at 19:35 -0600, John Arbash Meinel wrote:
> Robert Collins wrote:
> > Not for 0.7rc1, but IMO definately for 0.7: the basis inventory should
> > be 'basis-inventory', not 'basis-inventory.$revid'. (Ideally, it should
> > be 'checkout/basis-inventory'.
> 
> For the basis inventory stuff, you could merge my branch:
> http://bzr.arbash-meinel.com/branches/bzr/inventory-w-revision-id/

I'll have a peek.

> It modifies all inventories to make them:
> <inventory format="5" file_id="" revision_id="">
> 
> (Note, if we ever actually paid attention to the inventory_sha1 present
> in revision xml, this change would break them).
> 
> I could certainly change it so that only basis-inventory gets a
> revision_id, but I thought it would be moderately useful for all
> inventories to have it.

I don't have a strong thought. Martin ?

> > 
> > Also, there should be a format bump for 0.7 to reflect our format
> > changes that snuck in. (it should remove ancestry.weave and clean out
> > any stale basis-inventory files)
> > 
> > Rob
> > 
> 
> That would be nice. Plus as you mentioned it gives us the chance to put
> in more branch version support. Were you thinking to do this as a
> feature thing, where inside the code we would have 'if
> self._branch_version == X:', or were you thinking to have more of a
> branch factory, where you end up with BzrBranch6, etc.
> The first seems to get ugly fast, the second seems like there would be a
> lot of code duplication.

Neither ;). I have not done an audit to see whether the varying
behaviour is sufficiently large or small as to warrant some specific
form of factoring. Offhand I'd either go for a strategy - a class that
encapsulates a group of varying behaviour (and we can have multiple
strategies - one for each set of varying code), or sub classes of
branch.

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060105/cfdca6c0/attachment.pgp