merging johns integration to mine..

[Robert Collins]

On Tue, 2006-01-03 at 09:48 -0600, John Arbash Meinel wrote:

> By the way, you did fuck up fancy_rename (because other places raise
> IOError). I'm surprised you didn't see it in ./bzr selftest, because I did.
> 
> Anyway, I updated the code, and it is in my jam-integration branch.

Thanks.

> Also, I found that the doctest in errors.py was breaking. I think the
> problem was that hasattr() was creating a new exception, which messes up
> sys.exc_value. So I switched to
> 
> >>> path = getattr(sys.exc_value, 'path', None)
> 
> So that hopefully when we see timeout exceptions we'll get the correct
> traceback instead of *another* exception.
> 
> Do you think we should change the
> try:
>   raise NotBranchError(path='/foo')
> except:
> 
> to
> try:
> ...
> except NotBranchError:
> 
> so that we don't catch alternative exceptions?

Makes sense to me.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060104/fb1a1215/attachment.pgp