[RFC] weave refactoring

[Robert Collins]

On Mon, 2005-12-12 at 19:02 +0100, Johan Rydberg wrote:
> Which brings me to how revision signatures are supposed to be stored.
> Right now they are stored alongside the revisions in the revision
> store.  Which means there can only be one signature per revision.
> 
> Should the signatures always to tightly coupled with the revisions?

At this point, yes. The invariants should be:
 * If a signature is present, pull/push should always preserve it.
 * You cannot have a signature without a revision for it.

> If so, the responsibility for storing signatures can be moved to the
> new RevisionStore class.  If not, the concept of signature store can
> be re-introduced. 

Works for me.

> Are there any plans on support several signatures per revision?  Is
> there a need?   For knits there could be a separate signature-knit
> storing multiple signatures.  
> 
> My preference is to have a separate signature store, that way the
> underlying history format can store the signatures as they like, if it
> supports it at all.  
> 
> Comments?  Ideas?  Robert?

Either approach is fine. There are no -hard- plans for multiple
signatures for revisions, mainly because it has not been thought through
(and a few seconds thought shows enough hair that doing it without
specific use cases and review of them would be... hazardous).

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051215/d122b52b/attachment.pgp