[RFC] weave refactoring

[David Allouche]

On Mon, 2005-12-12 at 19:02 +0100, Johan Rydberg wrote:
> The reason I want to do this is to abstract away how revisions are
> stored.  Right now they are stored as plain files. With knits they
> will (most likely) be stored in a versioned file.  For history deltas
> the revision information is stored in the hdelta alongside text
> deltas.  So some kind of abstraction of a "revision store" is needed.
> 
> Which brings me to how revision signatures are supposed to be stored.
> Right now they are stored alongside the revisions in the revision
> store.  Which means there can only be one signature per revision.
> 
> Should the signatures always to tightly coupled with the revisions?
> If so, the responsibility for storing signatures can be moved to the
> new RevisionStore class.  If not, the concept of signature store can
> be re-introduced. 
> 
> Are there any plans on support several signatures per revision?  Is
> there a need?   For knits there could be a separate signature-knit
> storing multiple signatures.  

At the time signatures were introduced, I remember Robert explicitly
said that multiple signatures for a revision should be supported in the
future. The current "at most one signature per revision" implementation
was just a way of simplifying the problem to get the important
functionality delivered early.

Multiple signatures per revision can be useful, for example, to register
approval of a revision by a reviewer.

> My preference is to have a separate signature store, that way the
> underlying history format can store the signatures as they like, if it
> supports it at all.  
> 
> Comments?  Ideas?  Robert?

Apparently, this email has fallen through the cracks. CCing Robert to
try and catch his attention.
	
-- 
                                                            -- ddaa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051214/13cbdccf/attachment.pgp