patch: more sftp unit tests
John Arbash Meinel
john at arbash-meinel.com
Fri Dec 9 14:57:55 GMT 2005
Robert Collins wrote:
> On Thu, 2005-12-08 at 03:28 -0800, Robey Pointer wrote:
>
>> The stub sftp server can now be configured to use a home folder for
>> relative paths, and the TestCaseWithSFTPServer now takes an url path
>> and relative home folder for configuration. I just subclassed it
>> twice to exercise all 3 url formats ... which is 17 tests each, and
>> not speedy tests, so prepare to wait longer while they run. :)
>
> they are slow aren't they: 8-10 times slower than the matching HTTP
> tests. and about 400 times slower than the local file system matching
> tests.
>
> So - is this something we can fix (is paramiko having performance
> issues ?)
>
> AIUI other than the handshake SFTP should be -fast- locally, and the
> handshake is surely not worth 1 second of cpu time on my 5 month old
> laptop.
>
> Rob
>
Part of the problem (I believe), is how the timeout stuff is working.
That you currently have a specific wait time before the thread will
clean itself up.
We might also be incurring some sort of host lookup + reverse address
lookup. (Usually the latter one is the expensive part).
It could be the startup time for the ssh server. In which case we could
consider spawning the SSH server at some other time, and clean it up
independently of each test case. Then each test case would just tell the
SSH server what to consider as root, rather than spawning an entire new one.
I guess we need to profile to figure out where the time is spent.
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051209/9c7448cb/attachment.pgp
More information about the bazaar
mailing list