any more sftp fixes?

John A Meinel john at arbash-meinel.com
Thu Dec 1 13:44:06 GMT 2005


Robey Pointer wrote:
> 
> On 30 Nov 2005, at 9:25, John A Meinel wrote:
> 
>> I just merged all of my sftp fixes into my integration branch. Am I
>> missing any work that people have done?
> 
> I just compared the jam-integration version of sftp.py with my local
> copy and the changes all look good, except for one missing line
> (mentioned below).
> 
> I'm not sure the weakref system will work, though -- I'd pondered that
> before, but in tests with the python CLI, the weak values were going
> away as soon as the last "real" reference to them died.  If that's true
> generally, then the cache has an automatic expiration of zero seconds,
> making it a lot less useful. :)
> 
> 
>> Robey, where did you put your disable prefetch changes? I disabled it in
>> my own way (with a flag that makes it easy to toggle for testing), but I
>> would guess that wherever that change exists you might have more changes.
>> I've merged both your bzr.sftp branch, and your bzr.robey (which I think
>> already merged bzr.sftp).
> 
> I've stopped using the branches since they're so expensive right now --
> I just posted the patches here.  The one you're missing is changing
> mkdir to "makedirs" on line 171.  Windows people need that.

Actually, I don't think it should be done quite like that. I don't want
to always run makedirs instead of makedir. We just need the thing that
creates the ~/.bazaar directory to know that it needs to make
%APPDATA%/Bazaar and %APPDATA%/Bazaar/2.0
But I'll go ahead and do that.

John
=:->

> 
> robey
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051201/98320c42/attachment.pgp 


More information about the bazaar mailing list